Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram2d #2262

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Histogram2d #2262

wants to merge 11 commits into from
+541 −51

Conversation

AlexanderKalistratov
Copy link
Collaborator

@AlexanderKalistratov AlexanderKalistratov commented Jan 14, 2025 •
edited
Loading

Implementation of histogram2d via already existing functionality of histogramdd.

histogram2d accepts 2 different arrays, while histogramdd accepts single two-dimensional array.
In order to avoid double copy (first to single array, second to supported type) histogram2d perform type checks before calling to histogramdd.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@AlexanderKalistratov AlexanderKalistratov force-pushed the histogram2d branch 3 times, most recently from 8cfd5db to 541e7d9 Compare January 15, 2025 02:16
@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2025 •
edited
Loading

Coverage Status

coverage: 71.275% (+0.08%) from 71.194%
when pulling 1006a94 on histogram2d
into d522480 on master.

@AlexanderKalistratov AlexanderKalistratov marked this pull request as ready for review January 15, 2025 13:57
@AlexanderKalistratov
Copy link
Collaborator Author

@antonwolfy @vlad-perevezentsev ready for review

@AlexanderKalistratov
Copy link
Collaborator Author

Link to documentation:
https://intelpython.github.io/dpnp/pull/2262/reference/generated/dpnp.histogram2d.html#dpnp.histogram2d

antonwolfy
antonwolfy reviewed Jan 17, 2025
View reviewed changes
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
@AlexanderKalistratov
Copy link
Collaborator Author

@antonwolfy please re-review

antonwolfy
antonwolfy approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one minor comment, but overall LGTM! Thank you @AlexanderKalistratov

dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull/2262/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderKalistratov @coveralls @antonwolfy